Fix wrap_openframe.py: parenthesize OEB inversion for parser#48
Merged
Fix wrap_openframe.py: parenthesize OEB inversion for parser#48
Conversation
Loom's sverilogparse cannot parse unary operators immediately before backslash-escaped identifiers (e.g. `~\io$name$oe`). Wrap the operand in parentheses: `~( \io$name$oe )` so the parser handles it correctly. Co-developed-by: Claude Code v2.1.44 (claude-opus-4-6)
robtaylor
force-pushed
the
fix/wrap-oeb-parens
branch
from
43ce7c0 to
b43e979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~( \io$name$oe )instead of~\io$name$oe~,!) immediately before backslash-escaped identifiersFixes MCU SoC Metal Simulation CI failure on PR #44.
Test plan