Fix wrap_openframe.py: use ~ instead of ! for OEB inversion#45
Merged
Fix wrap_openframe.py: use ~ instead of ! for OEB inversion#45
Conversation
Loom's sverilogparse cannot parse `!\escaped_name` (! immediately before backslash-escaped identifier). Using ~ (bitwise NOT) instead of ! (logical NOT) produces the same result for single-bit signals and is valid Verilog that the parser can handle. Co-developed-by: Claude Code v2.1.44 (claude-opus-4-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!to~in OEB (output enable bar) assign statements!\escaped_name- the!immediately before a backslash-escaped identifier causes a parse error~(bitwise NOT) produces the same result as!(logical NOT) for single-bit signalsThis fixes the MCU SoC Metal Simulation CI failure on PR #44 (auto/update-mcu-soc-data).
Test plan