Skip to content

Fix published CLI runtime startup#115

Open
kingmarh-hash wants to merge 1 commit into
ChiefOfGxBxL:masterfrom
kingmarh-hash:codex/fix-published-cli-runtime
Open

Fix published CLI runtime startup#115
kingmarh-hash wants to merge 1 commit into
ChiefOfGxBxL:masterfrom
kingmarh-hash:codex/fix-published-cli-runtime

Conversation

@kingmarh-hash

Copy link
Copy Markdown

Summary

  • move fs-extra into runtime dependencies so production installs include it
  • resolve the CLI version from the package root package.json instead of dist/package.json

Fixes #114.

Verification

  • Reproduced the published wc3maptranslator@5.0.0 failure with a clean npm install --omit=dev followed by wc3maptranslator --version: it failed on missing fs-extra.
  • npm test rebuilt successfully and ran 52/55 tests; the remaining 3 failures are existing binary round-trip assertions in TranslatorReversion.test.js unrelated to CLI startup.
  • npm pack --json --silent
  • Installed the generated tarball in a fresh temp project with --omit=dev; ./node_modules/.bin/wc3maptranslator --version prints 5.0.0.
  • npm ls fs-extra --all shows wc3maptranslator -> fs-extra@11.3.5.

Note: npm run lint currently fails on pre-existing no-explicit-any errors in src/CommonInterfaces.ts; this PR does not touch that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'fs-extra'

1 participant