Fix published CLI runtime startup#115
Open
kingmarh-hash wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs-extrainto runtime dependencies so production installs include itpackage.jsoninstead ofdist/package.jsonFixes #114.
Verification
wc3maptranslator@5.0.0failure with a cleannpm install --omit=devfollowed bywc3maptranslator --version: it failed on missingfs-extra.npm testrebuilt successfully and ran 52/55 tests; the remaining 3 failures are existing binary round-trip assertions inTranslatorReversion.test.jsunrelated to CLI startup.npm pack --json --silent--omit=dev;./node_modules/.bin/wc3maptranslator --versionprints5.0.0.npm ls fs-extra --allshowswc3maptranslator -> fs-extra@11.3.5.Note:
npm run lintcurrently fails on pre-existingno-explicit-anyerrors insrc/CommonInterfaces.ts; this PR does not touch that file.