Conversation
Closed
3 tasks
richardkiss
reviewed
Nov 22, 2023
Pull Request Test Coverage Report for Build 8424848351Details
💛 - Coveralls |
richardkiss
reviewed
Dec 7, 2023
richardkiss
reviewed
Dec 7, 2023
arvidn
reviewed
Dec 19, 2023
Quexington
reviewed
Mar 19, 2024
Quexington
left a comment
Contributor
There was a problem hiding this comment.
In chia_rs .as_atom() was changed to raise when .atom was None. If we make that same change here, it will simplify a lot of areas it seems.
altendky
commented
Mar 19, 2024
altendky
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for looking.
Quexington
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catch up of #107
Broad Concerns:
AssertionErrorif an object isNonewhere previously aTypeErrorwould have been raised where we take thelen()of the object.Draft For:
TODO:s