Skip to content

fix(security): prevent CSV format corruption and formula injection in export #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vedhant26 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): prevent CSV format corruption and formula injection in export #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions backend/controllers/csvDownload.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ function formatIcsDate(dateInput) {
return `${year}${month}${day}T${hours}${minutes}${seconds}Z`;
}

function escapeCsvField(value) {
let str = String(value || '');
if (/^[=+\-@]/.test(str)) {
str = "'" + str; // Prevent formula injection
}
return `"${str.replace(/"/g, '""')}"`;
}

function buildCalendarIcs(tasks = []) {
const dtstamp = formatIcsDate(new Date().toISOString());
const events = tasks
Expand Down Expand Up @@ -81,14 +89,14 @@ async function downloadData(req, res) {
const rows = [
['Task ID', 'Subject', 'Title', 'Due At', 'Status', 'Priority', 'Confidence Score', 'Notes'],
...data.map(task => [
task.id,
task.subject_name,
task.title,
task.due_at,
task.status,
task.priority,
task.confidence_score,
`"${(task.notes || '').replace(/"/g, '""')}"`,
escapeCsvField(task.id),
escapeCsvField(task.subject_name),
escapeCsvField(task.title),
escapeCsvField(task.due_at),
escapeCsvField(task.status),
escapeCsvField(task.priority),
escapeCsvField(task.confidence_score),
escapeCsvField(task.notes),
]),
];

Expand Down Expand Up @@ -123,4 +131,5 @@ module.exports = {
buildCalendarIcs,
formatIcsDate,
escapeIcsText,
escapeCsvField,
};