fix: prevent root directory exposure via express.static#967
Open
Vedhant26 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 Fix: Prevent Root Directory Exposure
Closes #900
Security Issue
The application was exposing the entire root directory statically via
app.use(express.static(__dirname));. This allowed anyone to access sensitive files directly from the browser, including:.env(API keys, secrets)studyplan.db(The entire SQLite database with user tasks/data)database.jsandserver.js(Backend source code)Solution
Removed the wildcard root static exposure and replaced it with specific routes for explicitly needed public files:
/support-pageexplicitly./,/logo.png, and/favicon.ico./css,/js,/support-page, etc.) are served, protecting the root directory contents from unauthorized access.