fix: properly escape CSV fields with commas, quotes, and newlines#951
Open
Akshita-2307 wants to merge 1 commit into
Open
fix: properly escape CSV fields with commas, quotes, and newlines#951Akshita-2307 wants to merge 1 commit into
Akshita-2307 wants to merge 1 commit into
Conversation
Author
|
Hi maintainers! This PR fixes CSV field escaping to properly handle fields containing commas, quotes, and newlines, preventing malformed CSV output. Would appreciate a review. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #862
All CSV fields are now properly escaped using a new \escapeCsvField\ helper that wraps fields containing commas, quotes, or newlines in double quotes and escapes internal quotes.