Skip to content

chore: record workspace baseline#946

Open
pranayukey200 wants to merge 1 commit into
Charushi06:mainfrom
pranayukey200:fix/navbar-mobile-907
Open

chore: record workspace baseline#946
pranayukey200 wants to merge 1 commit into
Charushi06:mainfrom
pranayukey200:fix/navbar-mobile-907

Conversation

@pranayukey200
Copy link
Copy Markdown

Title: Fix: Navbar responsive on mobile (fixes #907)

Summary

Makes the site header responsive on small viewports by replacing the overflowing desktop nav with an accessible hamburger menu and mobile menu UI. Prevents link/profile overlap and horizontal overflow on devices ≤768px.
What I changed

Added a mobile hamburger button and mobile menu markup in index.html.
Added responsive styles and mobile-menu styling in css/index.css.
Added a small, accessible JS toggle (open/close, outside-click, Escape) in js/app.js.
Files modified

index.html — hamburger + mobile menu markup, mobile logout hook
css/index.css — media query for <=768px, mobile menu styles
js/app.js — mobile menu toggle IIFE (accessibility + close behavior)
Why

On narrow screens the header links and profile controls were overflowing and overlapping. This change collapses those controls into a single, touch-friendly menu while preserving access to Profile and Logout.
How to test

Run the app locally (open index.html in browser or run your dev server).
In browser DevTools set viewport width < 768px:
Verify the desktop nav and profile buttons are hidden.
Verify the hamburger (☰) is visible.
Click the hamburger: the mobile menu opens showing vertical nav links and Profile / Logout buttons.
Click outside the menu or press Escape: menu closes.
Confirm no horizontal scroll produced by the header.
Optionally test on a real mobile device and attach screenshots.
Accessibility / notes for reviewers

The hamburger button has aria-expanded and the menu toggles aria-hidden.
Menu closes with Escape and outside clicks to support keyboard and touch flows.
If maintainers prefer an animated slide-in or a different breakpoint, I can adjust easily.
PR checklist

Includes responsive CSS and minimal JS only
Keeps profile/logout accessible on mobile
No layout regressions at larger breakpoints (desktop behavior unchanged)
(Optional) Add screenshot(s) demonstrating mobile before/after

Copilot AI review requested due to automatic review settings May 29, 2026 17:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a responsive mobile header menu with toggle behavior and a dedicated mobile logout action.

Changes:

  • Introduces a mobile “hamburger” button and a hidden mobile navigation/menu block in index.html.
  • Adds JS to toggle the mobile menu open/closed (including outside-click and Escape-to-close behavior).
  • Adds mobile-specific responsive styles for the header/menu in css/index.css.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
js/app.js Adds mobile menu toggle + close interactions (outside click / Escape) and ARIA state updates.
index.html Adds mobile menu markup and duplicates logout behavior for a new mobile logout button.
css/index.css Adds responsive CSS to hide desktop nav/actions and display the mobile menu UI on small screens.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread index.html
Comment thread index.html
Comment thread js/app.js
Comment thread css/index.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug:Navbar broken on mobile view

2 participants