fix: nlpStartOf() sets time to 00:00 instead of 23:59#924
Open
vipul674 wants to merge 1 commit into
Open
Conversation
The nlpStartOf() helper was incorrectly setting hours to 23 and minutes to 59, causing all NLP-extracted task due dates to be end-of-day instead of start-of-day. Changed to setHours(0, 0, 0, 0) for correct semantics. Fixes Charushi06#923
Author
|
@Charushi06 please review the pr |
Author
|
@Charushi06 review reminder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nlpStartOf()inserver.jsto set time to00:00:00instead of23:59:00Problem
The
nlpStartOf()helper was settingd.setHours(23, 59, 0, 0)— the end of the day — despite its name implying start-of-day. This caused every task extracted via the NLP fallback parser to havedue_atat 23:59 instead of 00:00.Fix
Impact
Fixes #923