Convert addReccasterEnvVars to linked list and create helper function for addReccaster* logic #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-ess
reviewed
Oct 14, 2025
simon-ess
reviewed
Oct 17, 2025
simon-ess
approved these changes
Nov 17, 2025
Contributor
Author
|
Cleaned up a few things. If this is all good then I can squash some of the commits so it's ready to merge |
simon-ess
reviewed
Nov 18, 2025
tynanford
force-pushed
the
env_vars_update
branch
from
bf9ab7a to
5fe78db
Compare
simon-ess
approved these changes
Nov 20, 2025
mdavidsaver
reviewed
Nov 20, 2025
tynanford
force-pushed
the
env_vars_update
branch
from
5fe78db to
323b399
Compare
… iocsh funcs and some cleanup
tynanford
force-pushed
the
env_vars_update
branch
from
323b399 to
c7d5e98
Compare
|
Contributor
Author
|
I will plan to merge this tomorrow unless there are objections |
Collaborator
|
Looks ok to me. 
Added unit tests, and still a net reduction in code lines! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in place of #117 so the git merging/commit history isn't messed up. I branched off the latest in master, cherry-picked @madelinespark 's two commits, and worked off that.
addReccasterEnvVarsandaddReccasterExcludePatternlogicIOCSHFUNCDEF_HAS_USAGEmessage foraddReccasterExcludePatternMadeline's commits already converted
addReccasterEnvVarsto a linked list implementation and updated all the unit tests.