Fix logical test when parsing WebSocket request.#187
Open
VaslD wants to merge 1 commit intoChangbaDevs:masterfrom
Open
Fix logical test when parsing WebSocket request.#187VaslD wants to merge 1 commit intoChangbaDevs:masterfrom
VaslD wants to merge 1 commit intoChangbaDevs:masterfrom
Conversation
WebSocket.m:116:11: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
VaslD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a critical typo.
[NSString caseInsensitiveCompare:]would never return null for a non-null string, thus the comparison would actually be reversed: Checking for"WebSocket"and then settingisWebSocketto false.