Fix hatchling direct reference error for BaSiCPy #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add [flatfield] optional dependency group - Install basicpy from QI2lab/BaSiCPy GitHub repo - Include matplotlib for flatfield visualization - Update [all] to include flatfield 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Allow direct Git references in optional dependencies by setting tool.hatch.metadata.allow-direct-references = true Fixes CI failure in PR #14 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hongquanli
added a commit
that referenced
this pull request
Jan 5, 2026
- Fix #1 & #6: Convert to float32 before arithmetic to avoid uint underflow - Fix #7: Clear flatfield/darkfield to None on load failure - Fix #8: Support 2D arrays (Y, X) by auto-converting to 3D (1, Y, X) - Fix #15: Only uncheck flatfield checkbox if no auto-load found 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tool.hatch.metadata.allow-direct-references = trueto pyproject.tomlProblem
CI failed in PR #14 with:
Test plan
pip install -e ".[dev]"🤖 Generated with Claude Code