mise port and python setup#253
Open
jasonmorais wants to merge 2 commits into
Open
Conversation
Contributor
Reviewer's GuideIntroduces mise-based Node.js and Python environment setup, documents prerequisite tooling and install commands, adds Python tooling requirements, and wires new install scripts into the monorepo while making a minor refactor to an OAuth2 login handler. Flow diagram for new install:all tooling setupflowchart TD
Dev[Developer in project root] --> A[Run pnpm run install:all]
A --> B[pnpm i
Install Node.js workspace dependencies]
A --> C[pnpm run install:python]
C --> D[python -m pip install -r requirements.txt
Install Sourcery and Python tools]
subgraph MiseEnvironment[Managed by mise.toml]
E[node 22.22.2]
F[python 3.13]
G[.venv Python virtualenv]
end
Dev --> MiseEnvironment
E -.provides runtime for.-> B
F -.creates.-> G
G -.used by.-> D
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The compressed ternary assignment for
safeNoncereduces readability compared to the previous multi-line version; consider reverting to a multi-line format or breaking it up for clarity. - The
install:pythonscript assumespythonis the correct interpreter name; consider usingpython3orpython -m pipvia an environment variable (e.g.,PYTHON) ormise execto avoid issues on systems wherepythonis not bound to the intended version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The compressed ternary assignment for `safeNonce` reduces readability compared to the previous multi-line version; consider reverting to a multi-line format or breaking it up for clarity.
- The `install:python` script assumes `python` is the correct interpreter name; consider using `python3` or `python -m pip` via an environment variable (e.g., `PYTHON`) or `mise exec` to avoid issues on systems where `python` is not bound to the intended version.
## Individual Comments
### Comment 1
<location path="readme.md" line_range="55" />
<code_context>
+This automatically:
+- Installs **Node.js v22.22.2** (from `mise.toml`)
+- Installs **Python 3.13** (from `mise.toml`)
+- Creates `.venv/` Python virtual environment when mise activates the project
+
+### Install dependencies
</code_context>
<issue_to_address>
**nitpick (typo):** Consider adding an article before ".venv/ Python virtual environment" for smoother grammar.
For example: "Creates a `.venv/` Python virtual environment when mise activates the project" or "Creates the `.venv/` Python virtual environment when mise activates the project."
```suggestion
- Creates a `.venv/` Python virtual environment when mise activates the project
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Set up unified Node.js and Python tooling via mise, add Python dependency management, and document the new installation and build workflow.
New Features:
Enhancements:
Documentation:
Chores: