Replace nvm with mise (#205)#209
Open
nnoce14 wants to merge 6 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Reviewer's GuideReplaces nvm-based Node setup with a workspace-level mise configuration, standardizes pnpm/Corepack workflows, updates developer docs accordingly, adds an axios dependency override, adjusts SonarJS settings, and removes the legacy .nvmrc while refreshing the pnpm lockfile. Flow diagram for mise and pnpm setup processflowchart TD
A["Start: Developer wants to set up repo"] --> B["Install mise (brew install mise or curl installer)"]
B --> C["Activate mise in shell (e.g. eval $(mise activate zsh))"]
C --> D["Clone repo and cd cellixjs"]
D --> E["Run mise install (provisions Node 22.22.2 and Python 3.13)"]
E --> F["Enable Corepack"]
F --> G["corepack prepare pnpm@10.30.1 --activate"]
G --> H["pnpm run clean"]
H --> I["pnpm install"]
I --> J["pnpm run build"]
J --> K["pnpm run dev (local dev environment)"]
J --> L["pnpm run verify (lint, tests, security, SonarCloud)"]
K --> M["End: Dev environment running"]
L --> N["End: Local CI-like verification complete"]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the README/docs where you replace
nvm usewithmise install, consider clarifying that this assumesmiseis already installed and on the PATH (e.g., a short note or link), so users don’t get stuck if they run the command in a fresh environment. - The API and domain package READMEs previously pinned Node v20 with
nvm use v20, but now rely on the workspace-widenode = "22.22.2"inmise.toml; double-check this change is intentional for those packages and, if so, reflect the new Node version expectation explicitly in those files. - Since the main setup instructions now use
pnpminstead ofnpm, it would be helpful to add a brief note or command for installingpnpmfor users who may not have it installed globally.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the README/docs where you replace `nvm use` with `mise install`, consider clarifying that this assumes `mise` is already installed and on the PATH (e.g., a short note or link), so users don’t get stuck if they run the command in a fresh environment.
- The API and domain package READMEs previously pinned Node v20 with `nvm use v20`, but now rely on the workspace-wide `node = "22.22.2"` in `mise.toml`; double-check this change is intentional for those packages and, if so, reflect the new Node version expectation explicitly in those files.
- Since the main setup instructions now use `pnpm` instead of `npm`, it would be helpful to add a brief note or command for installing `pnpm` for users who may not have it installed globally.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…setup (address review comments) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Updated docs: switched 'Getting Started' blog to use mise + pnpm, added brew recommendation and Corepack guidance. Commits pushed to feat/205-replace-nvm-with-mise. Pre-commit verify ran locally during commit. |
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The mise installation instructions are inconsistent across docs (
https://mise.runvshttps://get.mise.dev, with and without-fsSL); consider standardizing on the official recommended installer snippet in a single shared snippet or section and reusing it for all references. - The repeated inline setup sequences (install mise, activate,
mise install, Corepack/pnpm setup) in multiple docs/blog/copilot files could be refactored into a single canonical ‘Setup’ section that other documents link to, to reduce drift and make future updates easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The mise installation instructions are inconsistent across docs (`https://mise.run` vs `https://get.mise.dev`, with and without `-fsSL`); consider standardizing on the official recommended installer snippet in a single shared snippet or section and reusing it for all references.
- The repeated inline setup sequences (install mise, activate, `mise install`, Corepack/pnpm setup) in multiple docs/blog/copilot files could be refactored into a single canonical ‘Setup’ section that other documents link to, to reduce drift and make future updates easier.
## Individual Comments
### Comment 1
<location path="apps/docs/docs/intro.md" line_range="60" />
<code_context>
+- Azure Functions Core Tools (func) — required for local Functions runtime; follow the official install guide linked above
+- MongoDB (local or remote) or use Azurite for local Azure storage emulation (used by this repo)
+
+Clone and Setup
```bash
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing "Setup" to "Set up" in the heading for correct verb usage.
Since the heading describes an action, the verb form "set up" is grammatically correct, while "setup" is a noun. Updating the heading accordingly will improve clarity and correctness.
```suggestion
Clone and Set up
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…r and link docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Docs: canonical Developer setup added; mise installer standardized; link fix applied and verified. Build passed locally. Commits pushed to feat/205-replace-nvm-with-mise. |
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Mise installation and activation instructions are now spread across multiple files (intro.md, copilot-instructions, package READMEs, etc.); consider trimming these down to a short note that links to apps/docs/docs/setup.md to avoid future drift and keep onboarding canonical.
- The new axios override in the root package.json may affect all workspaces; if the intent is to constrain it to specific packages or to work around a particular issue, consider adding a brief comment or scoping it to the relevant package to make the motivation and impact clear.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Mise installation and activation instructions are now spread across multiple files (intro.md, copilot-instructions, package READMEs, etc.); consider trimming these down to a short note that links to apps/docs/docs/setup.md to avoid future drift and keep onboarding canonical.
- The new axios override in the root package.json may affect all workspaces; if the intent is to constrain it to specific packages or to work around a particular issue, consider adding a brief comment or scoping it to the relevant package to make the motivation and impact clear.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
gidich
previously approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces nvm with mise. Adds mise.toml, removes .nvmrc, updates docs to recommend mise, adds axios override ^1.15.0 and updates pnpm-lock.yaml.
Summary by Sourcery
Adopt mise as the standard toolchain manager and update tooling, docs, and configuration accordingly.
New Features:
Enhancements:
Documentation:
Chores: