Use attrs/cattrs instead of custom serialization#333
Draft
Use attrs/cattrs instead of custom serialization#333
Conversation
Collaborator
Author
|
Converting to draft for discussion around refactoring and config breakage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #306
This PR adds cattrs and attrs usage to remove us having to write custom ser/des code.
To keep supporting the ability to define
MethodConfigs and*Trainers outside TRLX however, we need to keep some of the custom serialization/deserialization (rather than just making aUnionof all the relevant config types and having cattrs deserialize it)As a further improvement, we could make
*TrainerConfigclasses as we have forMethodConfig, and instantiate the trainers from a method on the deserialized*TrainerConfig, rather than a singleTrainConfigwith a stringly-typed name of the trainer class to instantiate. This would also let us give the different trainers different args as they need rather than getting trainer specific args fromMethodConfig(likegen_kwargs)