Filter app download links by mobile web browser OS#623
Open
chrisnowak wants to merge 2 commits into
Open
Conversation
The "Download the App" widget now uses the OperatingSystem property from GetDeviceInfo to only show the app store link that integrates with the participant's mobile web browser: iOS shows only the Apple App Store link, Android shows only the Google Play link, and desktop (or an undetermined OS) shows both. The widget continues to only render on the web platform (hidden in the native app). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KogJDCU6R3ovcj4w2VboYr
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Distinguish the two things that filter the store links: the project's configured platforms (DesktopProjectSupports*) versus the mobile web browser's OS (Mobile*Browser), and name the hidden native-app case explicitly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KogJDCU6R3ovcj4w2VboYr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The "Download the App" widget now uses the OperatingSystem property from GetDeviceInfo to only show the app store link that integrates with the participant's mobile web browser: iOS shows only the Apple App Store link, Android shows only the Google Play link, and desktop (or an undetermined OS) shows both. The widget continues to only render on the web platform (hidden in the native app).
Security
Testing
Storybook should be sufficient; i've validated in the actual data the correct OperatingSystem keys here.
Documentation
@CareEvolution/api-docs.Reviewers
Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:
Consider "Squash and merge" as needed to keep the commit history reasonable on
main.