Skip to content

Fix accessing state for reactor networks containing FlowReactor#2098

Merged
ischoegl merged 2 commits into
Cantera:mainfrom
speth:fix-flowreactor-getstate
Mar 7, 2026
Merged

Fix accessing state for reactor networks containing FlowReactor#2098
ischoegl merged 2 commits into
Cantera:mainfrom
speth:fix-flowreactor-getstate

Conversation

@speth
Copy link
Copy Markdown
Member

@speth speth commented Mar 6, 2026

Changes proposed in this pull request

  • Add missing +translate_exception annotation for ReactorNet.getState
  • Add get_state_dae member for Python ReactorNet and FlowReactor classes

The first commit here should be cherry-picked into #2092.

AI Statement (required)

  • Limited use of generative AI. Standard or boilerplate code snippets were generated with AI and manually reviewed; all design, logic, and implementation decisions were made by the contributor. Examples: IDE code-completions or brief LLM queries for common patterns.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • AI Statement is included
  • The pull request is ready for review

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.55%. Comparing base (5864c86) to head (264383e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2098   +/-   ##
=======================================
  Coverage   77.55%   77.55%           
=======================================
  Files         451      451           
  Lines       52834    52846   +12     
  Branches     8836     8836           
=======================================
+ Hits        40973    40984   +11     
- Misses       8887     8888    +1     
  Partials     2974     2974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@speth speth marked this pull request as ready for review March 6, 2026 22:01
Copy link
Copy Markdown
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speth!

@ischoegl ischoegl merged commit 0366e39 into Cantera:main Mar 7, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants