Refactor: Secure uploads route with authentication and input validation#43
Open
mohdsubhan1756 wants to merge 1 commit into
Open
Refactor: Secure uploads route with authentication and input validation#43mohdsubhan1756 wants to merge 1 commit into
mohdsubhan1756 wants to merge 1 commit into
Conversation
Contributor
|
Since /uploads is no longer publicly accessible, please verify that existing frontend features (profile images, uploaded files, etc.) continue to work correctly with the authenticated route |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the wide-open public static file serving for
/uploadswith a protected, dedicated GET route to enforce access control and validate file requests.Key Changes
protectmiddleware to ensure only authenticated users can access uploaded files./^[a-zA-Z0-9._-]+$/) to ensure filenames contain only safe characters.filePath.startsWith(uploadsDir)to prevent attackers from executing path traversal attacks (e.g., trying to read sensitive files via../sequences).fs.existsSynccheck to return a proper404 File not founderror before attempting to send the file.