Fix iconv bug (empty body when mail encoded in quoted-printable)#86
Open
hamdouni wants to merge 3 commits intoCampbellSoftwareSolutions:masterfrom
Open
Fix iconv bug (empty body when mail encoded in quoted-printable)#86hamdouni wants to merge 3 commits intoCampbellSoftwareSolutions:masterfrom
hamdouni wants to merge 3 commits intoCampbellSoftwareSolutions:masterfrom
Conversation
Netzvamp
added a commit
to Netzvamp/docker-osticket
that referenced
this pull request
Nov 16, 2020
|
Hey, i've implemented your fix in my repo/pull request (https://github.com/Netzvamp/docker-osticket) . I had to change the URL to the CDN (as in docker-library/php#240 (comment) ) and put it in one line with the other RUNs for less layers. My tests where fine, so thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
I had some issue with emails resulting in empty ticket. I narrowed the problem to this state :
Here are 2 samples of complete email.
The first one "mail.good" works nicely.
The second "mail.bad" gives an empty ticket.
mail.good:
mail.bad:
The difference is "Content-Transfer-Encoding: quoted-printable" in the header and =E9 (encoded é) inside the email body.
To test them inside a container, I use the internal mail piping as :
php -q /data/upload/api/pipe.php < mail.goodTo fix that, I used this fix and it's now OK for the 2 samples.
Hope it helps.