feat: add get_pending_admin view to settlement#387
Open
Vvictor-commits wants to merge 1 commit into
Open
Conversation
Exposes the pending admin slot so integrators can detect an in-flight two-step admin handover without watching events. - Add get_pending_admin(env) -> Option<Address>: returns Some when set_admin has been called and accept_admin has not yet completed, None otherwise - Add test_get_pending_admin_none_before_nomination: asserts None when no transfer is in progress - Add test_get_pending_admin_some_after_nomination: asserts Some after set_admin, then None again after accept_admin - Existing test_accept_admin_fails_if_not_nominated covers the accept-without-pending panic path - Document get_pending_admin in docs/interfaces/settlement.json
|
@Vvictor-commits Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #340
Problem
CalloraSettlementstoresStorageKey::PendingAdminduring the two-step admin transfer but exposes no way to read it. Integrators have no way to detect an in-flight handover without watching events.Changes
contracts/settlement/src/lib.rsget_pending_admin(env) -> Option<Address>: readsStorageKey::PendingAdminfrom instance storage, returnsSomewhen a transfer is pending,Noneotherwise. No auth required — read-only view.contracts/settlement/src/test.rstest_get_pending_admin_none_before_nomination— returnsNonewhen nothing is pendingtest_get_pending_admin_some_after_nomination— returnsSome(new_admin)afterset_admin, thenNoneagain afteraccept_admincompletestest_accept_admin_fails_if_not_nominatedalready covers the accept-without-pending panic path ("no admin transfer pending")docs/interfaces/settlement.jsonget_pending_adminentry: returnsAddress | null, no panics, no authNo logic changes
Only additive — new view function and tests.