Skip to content

fix: Allow duplicate sub-assemblies #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathaniel-brough wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Allow duplicate sub-assemblies #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cadquery/assembly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,8 @@ def add(self, arg, **kwargs):
# enforce unique names
name = kwargs["name"] if kwargs.get("name") else arg.name
if name in self.objects:
raise ValueError(
f"Unique name is required. {name} is already in the assembly"
)
# Add a incremented number to the name
name = f"{name}_{len(self.objects)}"

subassy = arg._copy()

Expand Down
6 changes: 0 additions & 6 deletions tests/test_assembly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,12 +1792,6 @@ def test_constrain_with_tags(nested_assy):
nested_assy.constrain("SECOND/BOTTOM ? pts", "dummy", "Plane")


def test_duplicate_name(nested_assy):

with pytest.raises(ValueError):
nested_assy.add(None, name="SECOND")


def test_empty_solve(nested_assy):

with pytest.raises(ValueError):
Expand Down