-
Notifications
You must be signed in to change notification settings - Fork 399
Materials Support for STEP Import/Export #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This PR closes #1954 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1956 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 29 29
Lines 7922 7951 +29
Branches 1191 1194 +3
=======================================
+ Hits 7593 7621 +28
Misses 192 192
- Partials 137 138 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@adam-urbanczyk When you get a chance, could you take a look at the mypy error on this? I've had similar problems before where every change I make to the mypy error for reference: |
|
I think I fixed it, the overloads were not annotated properly. |
|
@adam-urbanczyk Thanks! |
adam-urbanczyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
lorenzncode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment, also there is a typo line 1067 test_assembly.py (earlier commit):
# Test the ability to has a material
"to have"
|
I'll wait for a day or two before merging in case I missed anything else. |
No description provided.