Skip to content

ERA5 updated radiation corrections#614

Open
blsaenz wants to merge 6 commits into
mainfrom
input-dataset-updates
Open

ERA5 updated radiation corrections#614
blsaenz wants to merge 6 commits into
mainfrom
input-dataset-updates

Conversation

@blsaenz

@blsaenz blsaenz commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Updated ERA5 shortwave, and now additionally longwave, radiation correction multipliers were developed by UCLA. These have been uploaded to the roms-tools-data repo, as ERA5_corrections.nc. Roms-tools now loads that file automatically from github instead of the older SSR_correction.nc. The 'lwrad' variable is updated similarly to the shortwave in surface_forcing.py. Docstrings and example notebooks were updated to indicate that longwave radiation is corrected in addition to shortwave, if correction is requested.

  • Closes #CSD-889
  • Passes pre-commit run --all-files
  • Changes are documented in docs/releases.md
  • New functionality has documentation

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@blsaenz blsaenz requested review from kthyng and smaticka June 8, 2026 05:45
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.30%. Comparing base (e9cbe3c) to head (d04bb4a).

❗ There is a different number of reports uploaded between BASE (e9cbe3c) and HEAD (d04bb4a). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (e9cbe3c) HEAD (d04bb4a)
glorys-regional-invariance 1 0
without-dask 3 0
with-dask-1 1 0
with-dask-and-xesmf-1 1 0
@@             Coverage Diff             @@
##             main     #614       +/-   ##
===========================================
- Coverage   89.41%   55.30%   -34.11%     
===========================================
  Files          28       28               
  Lines        6319     6325        +6     
  Branches     1123     1124        +1     
===========================================
- Hits         5650     3498     -2152     
- Misses        378     2538     +2160     
+ Partials      291      289        -2     
Flag Coverage Δ
glorys-regional-invariance ?
with-dask-1 ?
with-dask-2 51.55% <100.00%> (+0.04%) ⬆️
with-dask-and-xesmf-1 ?
with-dask-and-xesmf-2 54.95% <100.00%> (+0.04%) ⬆️
with-streaming 35.35% <12.50%> (-0.04%) ⬇️
without-dask ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
roms_tools/datasets/download.py 80.95% <ø> (-19.05%) ⬇️
roms_tools/datasets/lat_lon_datasets.py 67.43% <ø> (-23.30%) ⬇️
roms_tools/setup/surface_forcing.py 83.64% <100.00%> (-0.01%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kthyng kthyng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me. One comment is that this change seems like a black box (same as when it was just a shortwave radiation correction). Is there any more information that can be provided or is that unrealistic for this?

Also the tests aren't working yet, but maybe that is related to test data generation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants