ERA5 updated radiation corrections#614
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## main #614 +/- ##
===========================================
- Coverage 89.41% 55.30% -34.11%
===========================================
Files 28 28
Lines 6319 6325 +6
Branches 1123 1124 +1
===========================================
- Hits 5650 3498 -2152
- Misses 378 2538 +2160
+ Partials 291 289 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes 🚀 New features to boost your workflow:
|
kthyng
left a comment
There was a problem hiding this comment.
The changes look reasonable to me. One comment is that this change seems like a black box (same as when it was just a shortwave radiation correction). Is there any more information that can be provided or is that unrealistic for this?
Also the tests aren't working yet, but maybe that is related to test data generation?
Updated ERA5 shortwave, and now additionally longwave, radiation correction multipliers were developed by UCLA. These have been uploaded to the roms-tools-data repo, as ERA5_corrections.nc. Roms-tools now loads that file automatically from github instead of the older SSR_correction.nc. The 'lwrad' variable is updated similarly to the shortwave in surface_forcing.py. Docstrings and example notebooks were updated to indicate that longwave radiation is corrected in addition to shortwave, if correction is requested.
pre-commit run --all-filesdocs/releases.md