Skip to content

Conversation

@tomahim
Copy link

@tomahim tomahim commented Sep 15, 2014

Hi,

I really enjoy the work done on postman, it's beautiful and simple.

I needed to change the duration of the timeout, so I propose to add a provider which can be use during the config phase (so it can be extended in the future for others parameters).

Example of use :

angular.module('myApp', []).config(postmanSettingsProvider) {
    postmanSettingsProvider.setTimeout(4500);
});

If you agree with this, can you do the merge ?

Thank you

Hi, 

I really enjoy the work done on postman, it's beautiful and simple. 

I needed to change the duration of the timeout, so I propose to add a provider which can be use during the config phase (so it can be extended in the future for others parameters). 

If you agree with this, can you do the merge ?

Thank you
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make it postmanSettingsProvider in the config? Can you not name it the same as the factory and then just access it via name + Provider?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to name it "postman" but postmanProvider is undefined when I use it in the config. I guess it's a conflict with the factory.

@CWSpear
Copy link
Owner

CWSpear commented Sep 15, 2014

I like it 👍

Will you add some docs/usage in the README?

@tomahim
Copy link
Author

tomahim commented Sep 15, 2014

Ok i'm adding some lines to the Readme.

@tomahim
Copy link
Author

tomahim commented Sep 15, 2014

Done for the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants