[PD1-240] - migrate from poetry to uv for dependency management#1
[PD1-240] - migrate from poetry to uv for dependency management#1olivierpichon wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant change by migrating the project's Python dependency management from Poetry to uv. This transition streamlines dependency resolution and installation processes, leading to potentially faster development workflows and more efficient project setup. The changes involve updating configuration files and documentation to align with the new tool. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to migrate the project from Poetry to uv for dependency management. The changes correctly update configuration files like pyproject.toml, .claude/settings.json, and README.md, and replace poetry.lock with uv.lock.
However, the migration is critically incomplete. The Python source files for the hooks still contain hardcoded calls to poetry, which will cause them to fail in an environment without Poetry installed. This defeats the purpose of the migration.
The following files must be updated to replace poetry run with uv run:
src/python_claude/hooks/ruff_format_hook.pysrc/python_claude/hooks/ruff_check_hook.pysrc/python_claude/hooks/mypy_hook.pysrc/python_claude/hooks/pytest_hook.pysrc/python_claude/hooks/session_start_hook.py(in the help text)
These changes are essential for the project to function correctly after the migration.
No description provided.