Skip to content

[PD1-240] - migrate from poetry to uv for dependency management#22

Open
olivierpichon wants to merge 1 commit intomainfrom
op/uv-migration
Open

[PD1-240] - migrate from poetry to uv for dependency management#22
olivierpichon wants to merge 1 commit intomainfrom
op/uv-migration

Conversation

@olivierpichon
Copy link

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's Python dependency management by migrating from Poetry to uv. This change simplifies the build process and standardizes how development commands are executed across the project, leading to potentially faster and more consistent dependency resolution and environment setup.

Highlights

  • Dependency Management Shift: The project has transitioned from using Poetry to uv for managing Python dependencies.
  • Configuration Updates: Project configuration files (.aider.conf.yml, .claude/settings.json, pyproject.toml) have been updated to reflect the use of uv commands and the new build system.
  • Lock File Migration: The poetry.lock file has been removed and replaced with a new uv.lock file.
Changelog
  • .aider.conf.yml
    • Updated the "test-cmd" to execute "pytest" using "uv run".
  • .claude/settings.json
    • Modified all command hooks to use "uv run python-claude" instead of "poetry run python-claude".
  • poetry.lock
    • Removed the Poetry-generated dependency lock file.
  • pyproject.toml
    • Refactored the build system configuration from Poetry to Hatchling.
    • Updated development dependencies to use uv's "dependency-groups" format.
  • uv.lock
    • Added a new lock file generated by uv, detailing all project dependencies and their versions.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the project from Poetry to uv for dependency management and hatchling for building. The configuration files have been updated accordingly. I've found one critical issue where a script was not updated as part of the migration, which will cause CI/local checks to fail.

dev = [
"pytest>=8.3.5,<9",
"mypy>=1.15.0,<2",
"ruff>=0.11.10,<1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While the dev dependencies are correctly migrated to uv's [dependency-groups], the scripts/lint.sh script which uses these dependencies (ruff, mypy, pytest) still uses poetry run. Since Poetry is being removed as part of this PR, this script will fail when executed.

All poetry run commands in scripts/lint.sh should be updated to use uv run.

For example:

- echo -e "poetry run ruff check --fix" "$@"
- poetry run ruff check --fix "$@"
+ echo -e "uv run ruff check --fix" "$@"
+ uv run ruff check --fix "$@"

@olivierpichon olivierpichon changed the title Migrate from poetry to uv for dependency management [PD1-240] - migrate from poetry to uv for dependency management Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant