[PD1-240] - migrate from poetry to uv for dependency management#22
[PD1-240] - migrate from poetry to uv for dependency management#22olivierpichon wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's Python dependency management by migrating from Poetry to uv. This change simplifies the build process and standardizes how development commands are executed across the project, leading to potentially faster and more consistent dependency resolution and environment setup. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the project from Poetry to uv for dependency management and hatchling for building. The configuration files have been updated accordingly. I've found one critical issue where a script was not updated as part of the migration, which will cause CI/local checks to fail.
| dev = [ | ||
| "pytest>=8.3.5,<9", | ||
| "mypy>=1.15.0,<2", | ||
| "ruff>=0.11.10,<1", |
There was a problem hiding this comment.
While the dev dependencies are correctly migrated to uv's [dependency-groups], the scripts/lint.sh script which uses these dependencies (ruff, mypy, pytest) still uses poetry run. Since Poetry is being removed as part of this PR, this script will fail when executed.
All poetry run commands in scripts/lint.sh should be updated to use uv run.
For example:
- echo -e "poetry run ruff check --fix" "$@"
- poetry run ruff check --fix "$@"
+ echo -e "uv run ruff check --fix" "$@"
+ uv run ruff check --fix "$@"afd8eee to
26d888a
Compare
No description provided.