Open
Conversation
|
Doxygen warnings output: (if empty, there are no warnings). Please correct any warnings before merging. /github/workspace/src/filters/IMU_filter.hpp:29: warning: argument 'IMU_data' of command @param is not found in the argument list of IMU_filter::init_EKF_6axis(IMU_data data)
/github/workspace/src/filters/IMU_filter.hpp:31: warning: The following parameter of IMU_filter::init_EKF_6axis(IMU_data data) is not documented:
parameter 'data'
/github/workspace/src/filters/IMU_filter.hpp:32: warning: argument 'IMU_data' of command @param is not found in the argument list of IMU_filter::step_EKF_6axis(IMU_data data)
/github/workspace/src/filters/IMU_filter.hpp:35: warning: The following parameter of IMU_filter::step_EKF_6axis(IMU_data data) is not documented:
parameter 'data' |
Pandabear1125
requested changes
Apr 2, 2025
Contributor
Pandabear1125
left a comment
Pandabear1125
left a comment
There was a problem hiding this comment.
Looks good, just some documentation and style stuff.
| /// @brief the data structure that holds all the IMU data | ||
| struct IMU_data{ | ||
| /// @brief raw acceleration value (m/s^2) | ||
| float accel_X = 0; |
Contributor
There was a problem hiding this comment.
Indent this struct's members
| @@ -0,0 +1,244 @@ | |||
| #include "IMU_filter.hpp" | |||
|
|
|||
| void IMU_filter::init_EKF_6axis(IMU_data data){ | |||
Contributor
There was a problem hiding this comment.
You should link your paper on how this works. Or comment much more on the math.
| {helpgy, -helpgz, 1, helpgx}, | ||
| {helpgz, helpgy, -helpgx, 1} | ||
| }; | ||
| // [ 1, -(dt*gx)/2, -(dt*gy)/2, -(dt*gz)/2] |
Contributor
There was a problem hiding this comment.
delete commented code
| {2*x[1], 2*x[0], 2*x[3], 2*x[2]}, | ||
| {2*x[0], -2*x[1], -2*x[2], 2*x[3]} | ||
| }; | ||
| // [-2*q2, 2*q3, -2*q0, 2*q1] |
Contributor
There was a problem hiding this comment.
delete commented code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also changed imu sensor's file in Sensors and sensor manager
The sensor manager add only the add bias function which called fix_raw_data() and calibration_all() in IMU_sensor.cpp
IMU is working on infantry after test.