Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #67 +/- ##
==========================================
- Coverage 76.10% 74.51% -1.60%
==========================================
Files 4 4
Lines 1088 1177 +89
==========================================
+ Hits 828 877 +49
- Misses 260 300 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
4 tasks
This was
linked to
issues
Aug 31, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the nolds codebase by integrating Ruff for linting and formatting, updating Python version support, and improving code quality throughout.
- Updates Python support from 3.8+ to 3.10+ and adds Python 3.13 support
- Applies comprehensive Ruff formatting and linting with updated configuration
- Adds type hints across the codebase and modernizes import patterns
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates Python version requirements, Ruff configuration, and dependency formatting |
| nolds/test_measures.py | Adds type hints, modernizes test structure with subTests, and improves documentation |
| nolds/examples.py | Adds type hints, modernizes argument parsing, and improves code formatting |
| nolds/datasets.py | Adds type hints, switches to modern resource loading, and improves documentation |
| nolds/init.py | Reorganizes imports with proper formatting and adds all declaration |
| doc/source/conf.py | Updates string quotes and formatting consistency |
| CHANGELOG.md | Documents all changes made in this release |
| .vscode/settings.json | Enables Ruff formatting and linting in VS Code |
| .github/workflows/ci.yaml | Updates CI to test Python 3.10-3.13 range |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48, #45, and #46.