feat(core): STAC summaries in Collections#2052
Merged
Conversation
Contributor
Test Results 4 files ± 0 4 suites ±0 4m 32s ⏱️ + 1m 12s Results for commit 14ca62c. ± Comparison against base commit b2df124. This pull request removes 1 and adds 12 tests. Note that renamed tests count towards both.This pull request skips 1 test.♻️ This comment has been updated with latest results. |
Collaborator
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: 14ca62c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
Code Coverage (Windows)DetailsDiff against developResults for commit: 14ca62c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
01a09cf to
716b848
Compare
716b848 to
fc87c45
Compare
sbrunato
approved these changes
Mar 18, 2026
sbrunato
previously requested changes
Mar 18, 2026
eodag collection model now inherits 'Collection model from 'stac_pydantic' 'model_dump()' and 'model_dump_json()' methods are overwritten to get unset values and display 'stac_extensions' property if wanted new validators have been created the wrap validator has been updated to handle errors of an element in a dictionary or list field replace 'proprietary' by 'other' for collection metadata 'license' the default value of collection metadata 'instruments' is now set to None
when a sub-field do not pass validation, it is replaced by its default value
it converts string values of fields whose type is list in the model to list of strings
collection 'CLMS_HRVPP_ST' has already a link in file 'collections.yml'
fc87c45 to
14ca62c
Compare
cauriol
pushed a commit
that referenced
this pull request
Apr 23, 2026
jlahovnik
pushed a commit
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to this PR and fix this issue.
eodag collection model now inherits
Collectionmodel from librarystac_pydanticto be fully STAC-compliant. Some fields are adapted to eodag to deal with cases where values are not provided in the input, especially when fields are mandatory. Fieldkeywordsis adapted for typing reason.model_dump()andmodel_dump_json()methods are overwritten to get unset values and display 'stac_extensions' property if wanted. As it takes too long to setstac_extensionsfor a big amount of collections, a parameterdisplay_extensionshas been created to display it with these methods when needed.The wrap validator has been updated to handle errors of an element in a dictionary or list field as these fields are now accepted in the model.
Some validators have been created to deal with field
summaries, which is a dictionary whose key-value pairs are checked in the model. Pairs set directly in model fields have priority over the ones set in fieldsummaries.proprietaryis replaced byotherfor collection metadatalicensewhich still had this value in some collections.The default value of collection metadata
instrumentsis now set toNoneas it is not mandatory.