558 reporting intermediate solutions#561
Conversation
ThomSerg
left a comment
There was a problem hiding this comment.
Seems a nice quality-of-life improvement. But yeah, the one for exact seems hack-y, especially with the "warning" part. Is there a way to restore the solver afterwards?
|
Besides that it is never mentioned + silently enforced that "display" is only for optimization, it seems good to me. |
|
we could add the gcs callback also since that bug is fixed or not? |
…porting-intermediate-solutions # Conflicts: # cpmpy/solvers/z3.py
|
Made quite some changes to this PR after the last review, so maybe another round of revieuwing from @ThomSerg and/or @Wout4 would be appropriate before merging. I'm wondering if we should really fill the |
…mediate-solutions
|
I think the comments are addressed @ThomSerg |
|
I decided to take out the display support for Z3 after all. Alternative is to keep it supported, but skip z3 in the tests? |
ThomSerg
left a comment
There was a problem hiding this comment.
Very minor styling comments. For the rest looks good!
|
Processed comments and merged master into this one; but its missing a PR "approval" :) |
Following the discussion in #558.
It adds quite some code in all solver interfaces, but I tried to do it somewhat consistent.
Some solvers are missing still:
For Exact,it is somewhat hacky as we need to go through "runOnce" instead of the nice "toOptimal" function. So there will be some more ping-pong through the interface.