Solver var consistent return type#1017
Open
Dimosts wants to merge 4 commits into
Open
Conversation
IgnaceBleukx
requested changes
Jun 18, 2026
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
Collaborator
There was a problem hiding this comment.
Great, nice cleanups.
I would like to solver_vars to then also be typed? I think that was the original point anyway ; )
| @@ -123,18 +123,20 @@ def native_model(self): | |||
| return self.pdk_solver | |||
|
|
|||
| def _int2bool_user_vars(self): | |||
Collaborator
There was a problem hiding this comment.
Could you type this? Also a docstring would be useful : )
I'm also not entire sure about the function name, but its already there from before so thats fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #999