Add CSPLib examples from DCP-Bench-Open#1015
Conversation
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
There was a problem hiding this comment.
Great! Thanks for the extra examples.
Most of them look very clean, but we should make sure they follow our own guidelines.
I.e., use import cpmpy as cp and cp.sum etc instead of from cpmpy import *.
Other comments are mainly related to default arguments, and what happens if we change them.
|
|
||
| model = Model() | ||
|
|
||
| x = boolvar(shape=num_shifts, name="x") |
There was a problem hiding this comment.
Ah so the goal is just to select the shifts, not necessarily asign them to worker too?
There was a problem hiding this comment.
Yes, it seems like a minimal version, in which each worker is assigned to a shift trivially.
|
Thanks for the feedback, let me know if you have any further comments! |
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
There was a problem hiding this comment.
Great improvement already.
I've had some fun with prob18 as there were lots of simplifications possible, let me know if you don't like some stuff ; )
Some more comments, and a general theme: how to handle the default case?
I would just put them as default arguments, and add asserts to ensure the dimensions of all arguments provided to the function are compatible
|
Thanks for the detailed comments, I think most of them are addressed, let me know if anything else remains! |
2 participants
No description provided.