Skip to content

Update pull_request_template.md#47

Open
ihorsikora wants to merge 1 commit into
devfrom
ihorsikora-patch-1
Open

Update pull_request_template.md#47
ihorsikora wants to merge 1 commit into
devfrom
ihorsikora-patch-1

Conversation

@ihorsikora

Copy link
Copy Markdown
Collaborator

🛠 Changes being made

What's the context for the changes?

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 How was it tested? / Demo

How do you know the changes are safe to ship to production? Please, explain the scenario, add screenshots.

📸 Screenshots

If you made UI changes, what are the before an afters?

🏎 Quality check

  • Set base branch to main.
  • Pull request is prepared: Added to sprint, added yourself as assignee, reviewers are added.
  • PR is not very big (about 200 lines of change ideally).
  • I have added comments to my code, particularly in hard-to-understand areas.
  • Doesn't create any new FIXME or TODO comments. If not, please explain.
  • Tested manually (explained the scenario, added screenshots)
  • I have tested my changes locally before pushing them to this branch.
  • I have updated the documentation accordingly.
  • Followed best practice rules:https://google.github.io/styleguide/pyguide.html

@github-actions

Copy link
Copy Markdown

Coverage report

Note

Coverage data for the default branch was not found.
This usually happens when the action has not run on the default
branch yet, for example right after deploying it into the workflows.

The coverage rate is 33.33%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant