Skip to content

[FIX] term 동적으로 받아오도록 수정#402

Merged
ujinsim merged 1 commit into
mainfrom
fix/#401
Jun 27, 2026
Merged

[FIX] term 동적으로 받아오도록 수정#402
ujinsim merged 1 commit into
mainfrom
fix/#401

Conversation

@ujinsim

@ujinsim ujinsim commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

🔥 연관 이슈

🚀 작업 내용

term 동적으로 받아오도록 수정

🤔 고민했던 내용

💬 리뷰 중점사항

Summary by CodeRabbit

  • Bug Fixes
    • 관리자 보고서에서 현재 학기 정보가 실제 최신 값으로 반영되도록 개선했습니다.
    • 학기 상태(현재/마감/미래) 표시가 더 정확해졌습니다.

@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ddingdong-fe Ready Ready Preview, Comment Jun 27, 2026 9:38am

@github-actions github-actions Bot requested a review from JangYEhoon00 June 27, 2026 09:35
@github-actions github-actions Bot added the fix 에러 픽스 label Jun 27, 2026
@github-actions github-actions Bot requested a review from keemsebin June 27, 2026 09:35
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2837bcdf-5aaa-48d4-a3f5-93dab4d55dd4

📥 Commits

Reviewing files that changed from the base of the PR and between 44b7da3 and a2af3ae.

📒 Files selected for processing (1)
  • apps/web/app/admin/report/_hooks/useTerm.ts

Walkthrough

useTerm 훅이 하드코딩된 현재 term 값을 제거하고, reportQueryOptions.currentTerm()useSuspenseQuery로 조회해 isClosed, isFuture, currentTerm을 계산하도록 변경되었습니다.

Changes

활동보고서 term 조회 전환

Layer / File(s) Summary
현재 term 조회와 파생값 계산
apps/web/app/admin/report/_hooks/useTerm.ts
useTermuseSuspenseQuery로 현재 term을 가져오고, 응답값으로 isClosed, isFuture, currentTerm을 계산한다.

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • COW-dev/ddingdong-fe#400: useTermcurrentTerm 고정값을 도입한 변경과 같은 훅을 대상으로, 현재 term 계산 경로를 되돌리는 흐름이다.

Suggested labels

hotfix

Suggested reviewers

  • JangYEhoon00
  • keemsebin
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed [FIX] 접두사와 term을 동적으로 받아오도록 수정한다는 핵심 변경이 일치합니다.
Description check ✅ Passed 필수 섹션과 이슈 참조가 포함되어 있어 전반적으로 템플릿을 충족합니다.
Linked Issues check ✅ Passed #401의 활동보고서 term을 기존 동작에 맞게 동적으로 가져오도록 변경해 요구사항을 충족합니다.
Out of Scope Changes check ✅ Passed 제공된 변경 내용은 useTerm 훅의 term 처리 개선에만 국한되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ujinsim ujinsim merged commit e71ce9b into main Jun 27, 2026
9 checks passed
@ujinsim ujinsim deleted the fix/#401 branch June 27, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 에러 픽스

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 활동보고서 term 동적으로 받아오도록 수정

1 participant