Skip to content

[FIX] 아이콘 사이즈 변경#398

Merged
keemsebin merged 3 commits into
mainfrom
feat/#397-iconSize
May 1, 2026
Merged

[FIX] 아이콘 사이즈 변경#398
keemsebin merged 3 commits into
mainfrom
feat/#397-iconSize

Conversation

@keemsebin

@keemsebin keemsebin commented May 1, 2026

Copy link
Copy Markdown
Collaborator

🔥 연관 이슈

🚀 작업 내용

  • 기존에 아이콘 svg viewBox 비율이 일정하지않아 아이콘이 크게 보이는 문제가 있어 수정 진행했습니다.

AS-IS
image

TO-BE
image

Summary by CodeRabbit

릴리스 노트

  • 스타일 개선
    • 드롭다운 및 선택 컴포넌트의 아이콘 크기를 조정하여 시각적 일관성을 향상했습니다.
    • 선택 버튼의 패딩을 조정하여 레이아웃을 최적화했습니다.
    • 아코디언 컴포넌트의 아이콘 기본 크기를 업데이트했습니다.

@vercel

vercel Bot commented May 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ddingdong-fe Ready Ready Preview, Comment May 1, 2026 11:00am

@github-actions github-actions Bot added the fix 에러 픽스 label May 1, 2026
@github-actions github-actions Bot requested review from JangYEhoon00 and ujinsim May 1, 2026 10:52
@coderabbitai

coderabbitai Bot commented May 1, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@keemsebin has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 33 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 22ba408f-1da7-4b58-94bb-55f9385efd1d

📥 Commits

Reviewing files that changed from the base of the PR and between a424f12 and 7e7429a.

📒 Files selected for processing (2)
  • packages/shared/ui/Header/Header.stories.tsx
  • packages/shared/ui/ProgressBar/ProgressBar.stories.tsx

요약

여러 컴포넌트의 드롭다운 및 아코디언 아이콘 크기를 1520에서 2224로 증가시키는 UI 스타일 업데이트와 함께 TypeScript 설정 및 Turbo 빌드 구성을 조정합니다.

변경 사항

Cohort / File(s) 요약
드롭다운 아이콘 크기 조정
apps/web/app/admin/apply/[id]/_components/filter/StatusDropdown.tsx, apps/web/app/admin/apply/new/_components/question/QuestionTypeSelect.tsx, apps/web/app/admin/member/_components/ExcelDropdown.tsx, packages/shared/ui/Select/SelectButton.tsx
드롭다운 버튼의 화살표 아이콘 크기를 1520에서 2224로 증가. StatusDropdown에서는 Tailwind 클래스 순서도 조정.
아코디언 아이콘 크기 조정
packages/shared/ui/Accordion/Accordion.tsx, packages/shared/ui/Accordion/Accordion.stories.tsx
아코디언 항목 아이콘 기본 크기를 13.5에서 24로 변경. 스토리에서는 iconSize 값을 12에서 30으로 업데이트.
TypeScript 설정 업데이트
packages/shared/tsconfig.json
TypeScript 컴파일 대상에서 .stories.tsx 파일을 제외하는 설정 제거. 스토리 파일이 이제 포함 규칙에 따라 컴파일 대상에 포함 가능.
빌드 구성 수정
turbo.json
dev 태스크의 의존성을 ^build에서 ^dev로 변경. 캐싱 및 지속성 설정은 유지.

예상 코드 리뷰 소요 시간

🎯 2 (Simple) | ⏱️ ~10 분

제안 라벨

⚛️ 프론트엔드

제안 리뷰어

  • ujinsim
  • yougyung
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning 아이콘 크기 수정 목표와 관련하여 packages/shared/tsconfig.json의 stories.tsx 제외 제거와 turbo.json의 dev 의존성 변경은 범위 외 변경으로 보입니다. tsconfig.json과 turbo.json 변경이 #397의 아이콘 크기 수정 목표와 어떤 연관이 있는지 설명하거나, 이들 변경을 별도 PR로 분리하는 것을 권장합니다.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive PR은 #397의 요구사항인 아이콘 크기 수정을 다양한 컴포넌트에서 구현했으나, tsconfig.json과 turbo.json 변경은 이슈의 목표와 무관합니다. tsconfig.json의 stories.tsx 제외 제거와 turbo.json의 dev 의존성 변경이 아이콘 크기 수정과 어떤 관계가 있는지 명확히 설명하시기 바랍니다.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 '[FIX] 아이콘 사이즈 변경'으로 변경 사항의 핵심(아이콘 크기 수정)을 명확하게 요약하고 있습니다.
Description check ✅ Passed PR 설명에는 연관 이슈(#397), 작업 내용, AS-IS/TO-BE 비교 이미지가 포함되어 있으나 '고민했던 내용'과 '리뷰 중점사항' 섹션이 누락되었습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#397-iconSize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 54 minutes and 33 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Update: 2026년 05월 01일 19시 58분 56초
Storybook 미리보기: https://69ca943d51248ba5e1094fac-gllnvuifvt.chromatic.com/

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/shared/ui/Accordion/Accordion.tsx`:
- Around line 146-147: The code sets the icon fallback to 24 via
rawIconSize/normalizedIconSize (using iconSize ?? context.iconSize ?? 24), but
the AccordionItemProps JSDoc `@default` still says 20; update the doc to match the
runtime fallback by changing the `@default` value in AccordionItemProps to 24 so
the documentation aligns with the actual behavior of iconSize, context.iconSize,
rawIconSize, and normalizedIconSize.

In `@turbo.json`:
- Line 24: The persistent task "dev" currently sets "dependsOn": ["^dev"], which
is invalid for persistent tasks; remove the "dependsOn" entry from the "dev"
task and either (recommended) depend on a non-persistent build task such as
"^build" instead, or (if you need to coordinate persistent tasks) replace the
dependency with "with": ["^dev"] and keep "persistent": true so Turborepo will
allow parallel persistent-task wiring; ensure you modify the "dev" task's keys
("dependsOn", "with", "persistent") accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9ee70837-61f6-41d0-8b9e-114823d3ce70

📥 Commits

Reviewing files that changed from the base of the PR and between 0ebdde0 and a424f12.

⛔ Files ignored due to path filters (2)
  • packages/shared/ui/assets/arrow-down.svg is excluded by !**/*.svg
  • packages/shared/ui/assets/arrow-up.svg is excluded by !**/*.svg
📒 Files selected for processing (8)
  • apps/web/app/admin/apply/[id]/_components/filter/StatusDropdown.tsx
  • apps/web/app/admin/apply/new/_components/question/QuestionTypeSelect.tsx
  • apps/web/app/admin/member/_components/ExcelDropdown.tsx
  • packages/shared/tsconfig.json
  • packages/shared/ui/Accordion/Accordion.stories.tsx
  • packages/shared/ui/Accordion/Accordion.tsx
  • packages/shared/ui/Select/SelectButton.tsx
  • turbo.json

Comment thread packages/shared/ui/Accordion/Accordion.tsx
Comment thread turbo.json
@keemsebin keemsebin merged commit fc1ff93 into main May 1, 2026
9 checks passed
@keemsebin keemsebin deleted the feat/#397-iconSize branch May 1, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 에러 픽스

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] 아이콘 크기수정

1 participant