Add bookmark read-side support: ArticleBookmarksReadService and bookmarked flag in ArticleData#518
Open
devin-ai-integration[bot] wants to merge 1 commit intodevin/1775649236-bookmark-data-layerfrom
Conversation
…ookmarked flag in ArticleData Co-Authored-By: Samir Chaudhry <schaudhry123@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds read-side support for bookmarks, following the existing
ArticleFavoritesReadServicepatterns:ArticleBookmarksReadServicemapper interface withisUserBookmark,userBookmarks(batch),userBookmarkArticleIds, andcountUserBookmarksArticleData.bookmarkedboolean field added (defaults tofalse)ArticleQueryService.fillExtraInfoupdated in both overloads to populate thebookmarkedflag for authenticated usersThe
userBookmarkArticleIdsandcountUserBookmarksmethods are defined for upcoming bookmark-listing endpoints but are not yet called in this PR.Review & Testing Checklist for Human
bookmarkedfield appears correctly in JSON API responses — Adding this field toArticleDatameans it will now be serialized in all article API responses. Confirm this is acceptable for downstream consumers.ArticleBookmarksReadService.xml— TheuserBookmarksquery goes directly againstarticle_bookmarks(unlike favorites which joins througharticles). Verify this is correct for thearticle_bookmarksschema from Task 1's migration.@AllArgsConstructorfield ordering — The newbookmarkedboolean sits betweenfavoritesCount(int) andcreatedAt(DateTime) inArticleData. All 6 existing test constructor call sites were updated. Compilation passing gives confidence, but worth a quick scan.Suggested manual test plan: Boot the app, create a user, create an article, bookmark it via the data layer, then
GET /articles/{slug}— confirm"bookmarked": trueappears. Fetch the same article unauthenticated and confirm"bookmarked"defaults tofalse.Notes
devin/1775649236-bookmark-data-layerwhich provides thearticle_bookmarkstable and write-side infrastructure.userBookmarkArticleIds,countUserBookmarks) are forward-looking for a future bookmarks listing API and have no callers yet.Link to Devin session: https://app.devin.ai/sessions/23f82d42a45f431e90cd635eb519e96e
Requested by: @schaudhry123