Migrate from Java 11 to Java 17#511
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
- Update sourceCompatibility and targetCompatibility from 11 to 17 - Update Spotless plugin from 6.2.1 to 6.25.0 for Java 17 support - Update SQLite JDBC from 3.36.0.3 to 3.45.1.0 for Java 17 compatibility - Pin Lombok to 1.18.30 for Java 16+ internal API access support - Upgrade Gradle wrapper from 7.4 to 7.6.4 for full Java 17 support Co-Authored-By: sophia.lyssy <sophia.lyssy@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step in the broader modernization effort (Java 17 is a prerequisite for the eventual Spring Boot 3.x upgrade). This PR updates the project's Java target from 11 to 17 and bumps dependencies that have known compatibility issues with Java 17's stronger encapsulation (JEP 403).
Changes:
All 68 tests pass locally with JDK 17.
Review & Testing Checklist for Human
.github/workflows/gradle.yml) may referencejava-version: '11'— this was not found in the local clone but is referenced in repo documentation. If the workflow exists, it needs to be updated to JDK 17 or CI will fail.InaccessibleObjectException. Run the app and exercise auth + article CRUD flows manually.spring-boot-starter-parent2.6.3. Verify annotation processing works correctly (getters/setters/builders generated properly).Recommended test plan: Run
./gradlew clean testwith JDK 17, then./gradlew bootRunand exercise the REST API (user registration, login, article CRUD, comments, favorites) and GraphQL endpoint (/graphql) to confirm no runtime issues.Notes
--add-opensJVM flags were added since no reflective access to JDK internals was found in source code. If runtime issues appear, flags may need to be added totasks.withType(Test)and the bootRun JVM args.Link to Devin session: https://app.devin.ai/sessions/784d18eb090842c6ab257d17f75ed4e5
Requested by: @sophialyssy-sys