Upgrade to Java 17 with dependency version bumps#510
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade to Java 17 with dependency version bumps#510devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Set sourceCompatibility/targetCompatibility to Java 17 - Bump Spring Boot 2.6.3 -> 2.7.18 - Bump DGS codegen plugin 5.0.6 -> 5.6.0 - Bump Spotless plugin 6.2.1 -> 6.12.0 - Bump DGS starter 4.9.21 -> 5.5.1 (via BOM) - Import DGS platform-dependencies BOM 5.5.1 for proper graphql-java alignment - Bump mybatis-spring-boot-starter 2.2.2 -> 2.3.0 - Bump jjwt 0.11.2 -> 0.11.5 - Bump sqlite-jdbc 3.36.0.3 -> 3.40.0.0 - Bump rest-assured 4.5.1 -> 5.3.0 - Upgrade Gradle wrapper 7.4 -> 8.5 - Update README to reference Java 17 Co-Authored-By: Joseph Goret <joseph.goret@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project from Java 11 to Java 17, bumping Spring Boot from 2.6.3 → 2.7.18 and all major dependencies to Java 17-compatible versions. Gradle wrapper upgraded from 7.4 → 8.5.
Dependency changes:
Notable: A
dependencyManagementblock importing the DGS platform-dependencies BOM (5.5.1) was added. Without it, the DGS codegen plugin's transitive dependency ongraphql-dgs-platform:5.0.4pinsgraphql-javato18.5, whilefederation-graphql-java-support:2.1.0(pulled by DGS 5.5.1) requiresgraphql-java:19.2, causing aNoSuchMethodErrorat runtime. The BOM import ensures consistent graphql-java resolution.All 68 tests pass locally. App boots and spotless formatting succeeds.
Review & Testing Checklist for Human
dependencyManagementblock inbuild.gradle) — this is the most impactful structural change and affects transitive dependency resolution across the project. Run./gradlew dependencies --configuration runtimeClasspath | grep graphql-javato confirmgraphql-java:19.2is resolved.SpringMVCpath matching strategy changed in 2.6+)../gradlew clean teston CI with Java 17 to verify all 68 tests pass in the CI environment, not just locally../gradlew bootRunthen hithttp://localhost:8080/tagsand a GraphQL query at/graphqlto verify both REST and GraphQL endpoints work.Notes
gradlew/gradlew.bat/gradle-wrapper.jardiffs are auto-generated by./gradlew wrapper --gradle-version 8.5.DefaultJwtServiceTest.java) is purely a spotless reformatting (line wrap).Link to Devin session: https://app.devin.ai/sessions/7a9bf3fc5cc044b1a3da0f985c61954f
Requested by: @josephgoret