Skip to content

Sync tool-call compat fixtures and update node test to match permissive tool-call policy#155

Merged
CJackHwang merged 1 commit intocodex/investigate-tool-execution-bugs-in-output-7ocr8ffrom
codex/review-and-fix-pr-#153-issues
Mar 22, 2026
Merged

Sync tool-call compat fixtures and update node test to match permissive tool-call policy#155
CJackHwang merged 1 commit intocodex/investigate-tool-execution-bugs-in-output-7ocr8ffrom
codex/review-and-fix-pr-#153-issues

Conversation

@CJackHwang
Copy link
Owner

Motivation

  • PR changes to the tool-call parser/sieve made the policy permissive (preserve original tool name casing and accept unknown tools when syntax is valid), and several compatibility fixtures and a Node unit test still encoded the old restrictive behavior, causing CI Unit Gates (Go + Node) to fail.

Description

  • Update expected Go compatibility fixtures under tests/compat/expected to reflect the new permissive behavior and preserved tool-name forms by changing toolcalls_allowlist_empty.json, toolcalls_unknown_name.json, toolcalls_case_insensitive_canonical.json, toolcalls_loose_normalize.json, and toolcalls_namespace_tail_normalize.json to include the original names and mark rejectedByPolicy: false.
  • Adjust the Node unit test tests/node/chat-stream.test.js to expect that unknown incremental tool-call deltas are kept (and recorded in seen) instead of being blocked, by changing the test name and assertions for filterIncrementalToolCallDeltasByAllowed.
  • The changes align the JS/Go test expectations with the updated parser/sieve semantics so parity tests pass again.

Testing

  • Ran ./tests/scripts/check-refactor-line-gate.sh and it completed successfully.
  • Ran ./tests/scripts/run-unit-all.sh (Go + Node) and the full unit gate passed locally with all Go and Node tests green after the fixture and test updates.
  • Ran the WebUI build via npm ci --prefix webui && npm run build --prefix webui and it completed successfully.

Codex Task

@vercel
Copy link

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ds2api Ready Ready Preview, Comment Mar 22, 2026 1:24pm

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@CJackHwang CJackHwang merged commit 47d4499 into codex/investigate-tool-execution-bugs-in-output-7ocr8f Mar 22, 2026
3 checks passed
@CJackHwang CJackHwang deleted the codex/review-and-fix-pr-#153-issues branch March 22, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant