Skip to content

Update toggle switch container view#490

Open
bipplane wants to merge 8 commits intoCATcher-org:mainfrom
bipplane:change-toggle-switch
Open

Update toggle switch container view#490
bipplane wants to merge 8 commits intoCATcher-org:mainfrom
bipplane:change-toggle-switch

Conversation

@bipplane
Copy link
Contributor

@bipplane bipplane commented Jul 2, 2025

Summary:

Fixes #494
Simple aesthetic change: Toggle switch bar has a hover style and wider dimensions for better responsiveness.

Type of change

  • ✨ New Feature/ Enhancement

Changes Made:

Updated toggle-switch-container to have highlight-on-hover, in line with the rest of the website's aesthetics.
Border and margins have been added/updated to fit the design as well.

Screenshots:

Normal look

Screenshot_15

On mouse hover

Screenshot_10

Proposed Commit Message:

Update toggle switch container view

Refactored the container view for the toggle switch component 
to improve its layout and responsiveness.

This change addresses inconsistencies in alignment, spacing and
visibility.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

@Arif-Khalid
Copy link
Contributor

Thank you @bipplane for your PR and it looks promising.
Could you create an issue outlining the problem and link it to this PR? It would help facilitate a discussion among the maintainers.

@bipplane
Copy link
Contributor Author

Thank you for the feedback! I'll create an issue accordingly.

Copy link
Contributor

@NorbertLoh NorbertLoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits to fix. I think this is a good fix. However, perhaps you could consider using a more subtle hover box shadow. Might be cleaner to change background/border colour.

@NorbertLoh
Copy link
Contributor

Your git commit message should have a subject line that fits the seedu guidelines. Where the subject should be in the imperative mood.

@NorbertLoh
Copy link
Contributor

Could we also prevent the highlighting of the arrow? just to make it slightly cleaner

@damithc
Copy link
Contributor

damithc commented Jul 25, 2025

Could we also prevent the highlighting of the arrow? just to make it slightly cleaner

Yup. Alternatively, highlight on hover. Another alternative is to use a separate overlay icon/button in the corner, which saves horizontal space as well.
image

@bipplane bipplane requested a review from NorbertLoh July 27, 2025 09:52
NorbertLoh
NorbertLoh previously approved these changes Aug 7, 2025
Copy link
Contributor

@NorbertLoh NorbertLoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 1 small nit pick. Otherwise LGTM!

@bipplane bipplane dismissed NorbertLoh’s stale review August 7, 2025 05:42

The merge-base changed after approval.

@bipplane bipplane requested a review from NorbertLoh August 7, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar toggle needs better dimensions and clearer visibility

4 participants