Feature/v2 password reset#42
Conversation
Co-authored-by: Mitchell Rysavy <mitchell.rysavy@gmail.com>
Co-authored-by: Mitchell Rysavy <mitchell.rysavy@gmail.com>
…dreset-tools-window
feat: tools window with supervisor verification for password reset
feat: Addded update button for file selection, progress window and data backup
…o feature/v2-password-reset
| if (success) | ||
| SuccessMessage = $"Password for '{Username}' was reset successfully."; | ||
| else | ||
| ErrorMessage = "Failed to reset password. Please check the username and try again."; |
There was a problem hiding this comment.
This was discussed in the field evaluation, and is not a blocker for merging this PR, but this form should close after successfully resetting a password to prevent confusion (maybe there can be a popup or other message that indicates success, outside of the form)
| if (Avalonia.Application.Current?.ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktop | ||
| && desktop.MainWindow != null) |
There was a problem hiding this comment.
Why can't the injected lifetime be used here? (Not sure who these changes are by - @luqmanrashad I think?)
| HorizontalAlignment="Center" | ||
| FontSize="14" | ||
| Foreground="{Binding StatusColor}"/> | ||
| </StackPanel> |
There was a problem hiding this comment.
One thing I noticed is that if there is an error message that gets displayed here, such as when an invalid zip file is passed, this cuts off the text. Maybe make it bigger, or make it wrap the text?
| { | ||
| collection.AddSingleton(ApplicationLifetime); | ||
| collection.AddSingleton(desktopLifetime); | ||
| } |
There was a problem hiding this comment.
This is a bit weird since I think ApplicationLifetime and desktopLifetime would refer to the same underlying variable here, so it's effectively just being added twice under different types/interfaces. I'm not saying it shouldn't happen, but is there a reason it's doing both and not just one of them?
4 participants
New scope of password reset feature and code refactor.