Rename single_node_default to single_node_exchange#1176
Conversation
|
Hi there, this is jenkins continuous integration... |
1 similar comment
|
Hi there, this is jenkins continuous integration... |
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/9ed1d7de-c7e2-493a-aa9f-7ff3e210384b Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>
single_node_default to single_node_exchange
|
cscs-ci run default |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run distributed |
msimberg
left a comment
There was a problem hiding this comment.
This looks like a no brainer. Plenty of other related to changes that could be made, but I think this change is good to go on its own.
* main: refactor: prefix VelocityAdvection internal attributes with underscore (#1180) fortran bindings: split py2fgen and bindings (#1185) Rename `single_node_default` to `single_node_exchange` (#1176) remove the duplication of fixtures (#1186) Update GT4Py to v1.1.9 (#1187) cleanup 3 unused vars from solve_nh_init (#1169)
single_node_defaultis ambiguous—it sits next tosingle_node_reductionsindefinitions.pybut doesn't convey that it's an exchange runtime. Renamed tosingle_node_exchangeto match its type (SingleNodeExchange) and mirror the naming of its sibling.decomposition/definitions.pymodel/common,model/atmosphere/diffusion, andmodel/atmosphere/advection(source + tests)📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.