Skip to content

Rename single_node_default to single_node_exchange#1176

Merged
msimberg merged 2 commits intomainfrom
copilot/rename-single-node-default
Apr 15, 2026
Merged

Rename single_node_default to single_node_exchange#1176
msimberg merged 2 commits intomainfrom
copilot/rename-single-node-default

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

single_node_default is ambiguous—it sits next to single_node_reductions in definitions.py but doesn't convey that it's an exchange runtime. Renamed to single_node_exchange to match its type (SingleNodeExchange) and mirror the naming of its sibling.

  • Renamed the module-level variable in decomposition/definitions.py
  • Updated all 11 consuming files across model/common, model/atmosphere/diffusion, and model/atmosphere/advection (source + tests)

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@jenkins-apn
Copy link
Copy Markdown

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

1 similar comment
@jenkins-apn
Copy link
Copy Markdown

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

Copilot AI linked an issue Mar 30, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Rename single_node_default to single_node_exchange Rename single_node_default to single_node_exchange Mar 30, 2026
Copilot AI requested a review from jcanton March 30, 2026 09:32
@jcanton
Copy link
Copy Markdown
Contributor

jcanton commented Mar 30, 2026

cscs-ci run default

@github-actions
Copy link
Copy Markdown

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

@jcanton
Copy link
Copy Markdown
Contributor

jcanton commented Mar 30, 2026

cscs-ci run distributed

Copy link
Copy Markdown
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a no brainer. Plenty of other related to changes that could be made, but I think this change is good to go on its own.

@msimberg msimberg marked this pull request as ready for review April 15, 2026 08:14
@msimberg msimberg requested a review from nfarabullini April 15, 2026 08:14
@msimberg msimberg merged commit e004c7f into main Apr 15, 2026
54 checks passed
@msimberg msimberg deleted the copilot/rename-single-node-default branch April 15, 2026 09:13
jcanton added a commit that referenced this pull request Apr 16, 2026
* main:
  refactor: prefix VelocityAdvection internal attributes with underscore (#1180)
  fortran bindings: split py2fgen and bindings (#1185)
  Rename `single_node_default` to `single_node_exchange` (#1176)
  remove the duplication of fixtures (#1186)
  Update GT4Py to v1.1.9 (#1187)
  cleanup 3 unused vars from solve_nh_init (#1169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename single_node_default to something different

5 participants