Implement more ds_map functions and make json_decode more accurate#246
Open
AloXado320 wants to merge 3 commits into
Open
Implement more ds_map functions and make json_decode more accurate#246AloXado320 wants to merge 3 commits into
AloXado320 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally wanted to implement the ds_map functions only but I realized it has some ties to how json values are decoded so here it is as a "whole package".
Implemented
ds_map_add_map,ds_map_add_list,ds_map_is_mapandds_map_is_list.As a bonus,
filename_nameis also implemented to properly parse name directories.All of the changes mentioned fixes the "LANG_ERROR" strings in Sonic Time Twisted.