feat: move TOC to left, add visibility toggle and focus keybinds#276
Open
harshafaik wants to merge 1 commit intoBuilditluc:mainfrom
Open
feat: move TOC to left, add visibility toggle and focus keybinds#276harshafaik wants to merge 1 commit intoBuilditluc:mainfrom
harshafaik wants to merge 1 commit intoBuilditluc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to accurately replicate the infobox displayed on wiki pages in the future, I've shifted the table of contents UX to the left, while adding a keybind for toggling it. With this:
Tab respects TOC visibility, if it is hidden, Tab does nothing until TOC is shown again.
Introduced pending_anchor to defer the heading jump until after the render cycle completes with the correct layout width, ensuring pixel-perfect navigation and fixing a race condition wherein the TOC visibility could cause incorrect scroll position.
My first PR, let me know if there are corrections to be made.