Prevent race condition in parallel build#17
Open
vlmarek wants to merge 1 commit into
Open
Conversation
Both make targets 'bins' and 'recommend' eventually need to link against sublib.o. The race happens when both targets are running in parallel and build sublib.o at the same time. - both 'bins' and 'recommend' start to compile sublib.o - 'recommend' - produces sublib.o - 'recommend' - links against sublib.o - 'bins' - just now finishes sublib.o overwriting the one from 'recommend' Now user runs 'make install' and install finds that 'recommend' is older than 'sublib.o' so needs to relink 'recommend'.
BuGlessRB
force-pushed
the
master
branch
4 times, most recently
from
4ca880f to
ffe0194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both make targets 'bins' and 'recommend' eventually need to link against sublib.o. The race happens when both targets are running in parallel and build sublib.o at the same time.
Now user runs 'make install' and install finds that 'recommend' is older than 'sublib.o' so needs to relink 'recommend'.