Skip to content

Fixing multiselect equls #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mamazu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing multiselect equls #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
553ad07
Fixing multiselect equls
mamazu Oct 9, 2025
11afceb
Second try
mamazu Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Traits/OrderItemCustomerOptionCapableTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,27 @@ public function equals(SyliusOrderItemInterface $item): bool

// iterate over all options and compare their values
foreach ($itemCustomerConfiguration as $code => $value) {
// If one option is multi-select and the other one isn't they're not equal
if (is_array($value) !== is_array($curItemCustomerConfiguration[$code])) {
return false;
}

// If it's multi-select
if (is_array($value)) {
if (count($value) !== count($curItemCustomerConfiguration[$code])) {
return false;
}

foreach ($curItemCustomerConfiguration[$code] as $optionKey => $multiSelectValue) {
if ($multiSelectValue->getOptionValue() !== $value[$optionKey]->getOptionValue()) {
return false;
}
}

return false;
}

// It's a normal value option
if ($curItemCustomerConfiguration[$code]->getOptionValue() !== $value->getOptionValue()) {
return false;
}
Expand Down