-
-
Notifications
You must be signed in to change notification settings - Fork 25
Add information about the shi to the README.md #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
94cdd42 to
5ccb6ba
Compare
5ccb6ba to
0693025
Compare
README.md
Outdated
| first activate the smart home interface (shi) in the settings, after which | ||
| they can be accessed via Modbus TCP (port 502, No BMS/GLT license required). | ||
| More detailed documentation on this API can be found at | ||
| [luxtronik/shi/README.md](https://github.com/Bouni/python-luxtronik/blob/master/luxtronik/shi/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link could probably be relative:
| [luxtronik/shi/README.md](https://github.com/Bouni/python-luxtronik/blob/master/luxtronik/shi/README.md). | |
| [luxtronik/shi/README.md](luxtronik/shi/README.md) |
If this doesn't work, it should be added to the bottom of the file as reference instead of exploding the line length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Wow, didn't expect you to work on this one, so thank you very much ;-). From my point of view, it's superb, happy to merge. Added minor nit-picking comments, feel free to address them (or ignore them ;-)). |
To ensure that the documentation was correct, I also had to:
unittoBaseFirst guess for #214