fix: Linting #36
Closed
fix: Linting #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add rebalancer warp command * fix: Test rebalancer command
* fix: Run anvil4 * fix: Add routeid and frequency to args * fix: Add anvil4 metadata * fix: Add chain 4 to helpers * fix: Test rebalancer monitoring using a deployed route * fix: Delete deployments on cleanup and dont persist state * fix: Accept string as param * fix: Send tokens before starting the rebalancer * fix: Format
* feat: Simple strat + tests * fix: Update strategy interface * fix: Add tolerance to strategy * fix: Make e2e faster * fix: Accept strategy tolerance arg * fix: Update format * fix: With snapshots * fix: Snapshots in helpers * fix: Test with tolerance * fix: Remove only * fix: Update strategy tolerance description * fix: Add sleep to parallel send
also, change the implementation to be event driven
fernandomg
reviewed
Apr 24, 2025
typescript/cli/src/commands/warp.ts
Outdated
Member
There was a problem hiding this comment.
I did something different, it's catching the error, wdyt?
Comment on lines
163
to
166
Member
There was a problem hiding this comment.
nice one, wdyt about the force: true option?
Comment on lines
185
to
209
Member
There was a problem hiding this comment.
I went this exact same path, but I rather keep what's currently done with the for await for chunks.
Author
There was a problem hiding this comment.
But the for await requires the promise executor to be async and the linter doesn't like that
Comment on lines
204
to
192
Member
There was a problem hiding this comment.
I would like to have this included tbh
we can later decide if it is worth having it moved to the utils package
fzavalia
force-pushed
the
feat/rebalancer-agent
branch
2 times, most recently
from
1349402 to
4264272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the error message to address the TODO