Open
Conversation
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 285d982 in 1 minute and 24 seconds
More details
- Looked at
526lines of code in9files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_rfv6kzCdizAFU0Jx
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| import { deepSort, expectArraysInObjectToContainSameElements } from '../../helpers/matchers'; | ||
| import { createTest } from '../../helpers/createTest'; | ||
| import { expect, it } from 'vitest'; | ||
| import { expect, expect, it } from 'vitest'; |
Contributor
There was a problem hiding this comment.
Remove the duplicated import of expect from vitest to clean up the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Introduced intermediary relations handling in BQL mutations with updates to core files and unit tests.
Key points:
test:typedb-mutationscript to runtypedb/unit/mutations/basic.test.ts.enrichSchemafunction.oppositeLinkFieldsPlayedBymapping.Generated with ❤️ by ellipsis.dev