Skip to content

fix: force even dimensions before H.264 encode (odd sizes broke ffmpeg CRF) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenobijon merged 1 commit into from
Jun 19, 2026
Merged

fix: force even dimensions before H.264 encode (odd sizes broke ffmpeg CRF) #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/gasbench/processing/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,16 @@ def apply_video_robustness_augmentations(

T, H, W, C = video_array.shape

# H.264 with yuv420p (both the ffmpeg -crf and cv2 avc1 encoders) requires
# even width and height; libx264 rejects odd dimensions outright. Trim a
# trailing row/column when needed so encoding succeeds instead of silently
# erroring into the fallback path (which would also mis-set method). At most
# one pixel per axis is dropped, and the frame is resized to target anyway.
even_h, even_w = H - (H % 2), W - (W % 2)
if (even_h, even_w) != (H, W) and even_h >= 2 and even_w >= 2:
video_array = video_array[:, :even_h, :even_w, :]
T, H, W, C = video_array.shape

method = "ffmpeg_crf"
compressed = _h264_roundtrip_ffmpeg(video_array, crf, fps)
if compressed is None:
Expand Down